cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Wed, 14 Oct 2015 12:06:05 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956789#comment-14956789
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41984944
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
    @@ -358,19 +442,28 @@ private String getVirtualRouterIP(Network network, Collection<String>
addressRan
             Set<Long> allIPsInCidr = NetUtils.getAllIpsFromCidr(subnet, cidrSize, new
HashSet<Long>());
     
             if (allIPsInCidr.size() > 3) {
    +            //get the second IP and see if it the networks GatewayIP
                 Iterator<Long> ipIterator = allIPsInCidr.iterator();
                 long vip = ipIterator.next();
                 if (NetUtils.ip2Long(network.getGateway()) == vip) {
    -                s_logger.debug("Gateway of the Network(" + network.getUuid() + ") has
the first IP " + NetUtils.long2Ip(vip));
    +                if (s_logger.isDebugEnabled()) {
    +                    s_logger.debug("Gateway of the Network(" + network.getName() + ")
has the first IP " + NetUtils.long2Ip(vip));
    +                }
                     vip = ipIterator.next();
                     virtualRouterIp = NetUtils.long2Ip(vip);
    -                s_logger.debug("So, reserving the 2nd IP " + virtualRouterIp + " for
the Virtual Router IP in Network(" + network.getUuid() + ")");
    +                if (s_logger.isDebugEnabled()) {
    +                    s_logger.debug("So, reserving the 2nd IP " + virtualRouterIp + "
for the Virtual Router IP in Network(" + network.getName() + ")");
    +                }
                 } else {
                     virtualRouterIp = NetUtils.long2Ip(vip);
    -                s_logger.debug("1nd IP is not used as the gateway IP. So, reserving"
+ virtualRouterIp + " for the Virtual Router IP for " + "Network(" + network.getUuid() + ")");
    +                if (s_logger.isDebugEnabled()) {
    +                    s_logger.debug("1nd IP is not used as the gateway IP. So, reserving"
+ virtualRouterIp + " for the Virtual Router IP for " + "Network(" + network.getName() + ")");
    --- End diff --
    
    Changed the latter message to contain the previous one.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message