cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Wed, 14 Oct 2015 09:32:05 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956564#comment-14956564
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41972301
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
---
    @@ -51,13 +61,91 @@ public boolean isL3Network() {
             return _isL3Network;
         }
     
    +    public boolean isVpc() {
    +        return _isVpc;
    +    }
    +
         public List<Map<String, Object>> getStaticNatDetails() {
             return _staticNatDetails;
         }
     
    +    public static class Builder extends CmdBuilder<ApplyStaticNatVspCommand> {
    +        private String _networkDomainUuid;
    +        private String _networkUuid;
    +        private String _vpcOrSubnetUuid;
    +        private boolean _isL3Network;
    +        private boolean _isVpc;
    +        private List<Map<String, Object>> _staticNatDetails;
    +
    +        public Builder networkDomainUuid(String networkDomainUuid) {
    +            this._networkDomainUuid = networkDomainUuid;
    +            return this;
    +        }
    +
    +        public Builder networkUuid(String networkUuid) {
    +            this._networkUuid = networkUuid;
    +            return this;
    +        }
    +
    +        public Builder vpcOrSubnetUuid(String vpcOrSubnetUuid) {
    +            this._vpcOrSubnetUuid = vpcOrSubnetUuid;
    +            return this;
    +        }
    +
    +        public Builder isL3Network(boolean isL3Network) {
    +            this._isL3Network = isL3Network;
    +            return this;
    +        }
    +
    +        public Builder isVpc(boolean isVpc) {
    +            this._isVpc = isVpc;
    +            return this;
    +        }
    +
    +        public Builder staticNatDetails(List<Map<String, Object>> staticNatDetails)
{
    +            this._staticNatDetails = staticNatDetails;
    +            return this;
    +        }
    +
    +        @Override
    +        public ApplyStaticNatVspCommand build() {
    +            return new ApplyStaticNatVspCommand(_networkDomainUuid, _networkUuid, _vpcOrSubnetUuid,
_isL3Network, _isVpc, _staticNatDetails);
    +        }
    +    }
    +
         @Override
         public boolean executeInSequence() {
             return false;
         }
     
    +    @Override
    +    public boolean equals(Object o) {
    +        if (this == o) return true;
    +        if (o == null || getClass() != o.getClass()) return false;
    +
    +        ApplyStaticNatVspCommand that = (ApplyStaticNatVspCommand) o;
    +
    +        if (_isL3Network != that._isL3Network) return false;
    +        if (_isVpc != that._isVpc) return false;
    +        if (_networkDomainUuid != null ? !_networkDomainUuid.equals(that._networkDomainUuid)
: that._networkDomainUuid != null)
    +            return false;
    +        if (_networkUuid != null ? !_networkUuid.equals(that._networkUuid) : that._networkUuid
!= null) return false;
    +        if (_staticNatDetails != null ? !_staticNatDetails.equals(that._staticNatDetails)
: that._staticNatDetails != null)
    +            return false;
    +        if (_vpcOrSubnetUuid != null ? !_vpcOrSubnetUuid.equals(that._vpcOrSubnetUuid)
: that._vpcOrSubnetUuid != null)
    +            return false;
    +
    +        return true;
    +    }
    +
    +    @Override
    +    public int hashCode() {
    +        int result = _networkDomainUuid != null ? _networkDomainUuid.hashCode() : 0;
    +        result = 31 * result + (_networkUuid != null ? _networkUuid.hashCode() : 0);
    +        result = 31 * result + (_vpcOrSubnetUuid != null ? _vpcOrSubnetUuid.hashCode()
: 0);
    +        result = 31 * result + (_isL3Network ? 1 : 0);
    +        result = 31 * result + (_isVpc ? 1 : 0);
    +        result = 31 * result + (_staticNatDetails != null ? _staticNatDetails.hashCode()
: 0);
    +        return result;
    +    }
    --- End diff --
    
    We can't, the <code>toString()</code> method is made <code>final</code>
in the base class <code>Command</code>


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>         Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message