cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8708) Use Google Gson 2.3.1
Date Fri, 23 Oct 2015 18:02:27 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971478#comment-14971478
] 

ASF GitHub Bot commented on CLOUDSTACK-8708:
--------------------------------------------

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/932#issuecomment-150648494
  
    @DaanHoogland I have the same result as @borisroman reports:
    
    ```
    ==== Deploy DC Started ====
    Exception Occurred: ['Traceback (most recent call last):\n', '  File "/data/git/cs1/cloudstack/tools/marvin/marvin/deployDataCenter.py",
line 254, in createPrimaryStorages\n    ret = self.__apiClient.createStoragePool(primarycmd)\n',
'  File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line
1727, in createStoragePool\n    response = self.connection.marvinRequest(command, response_type=response,
method=method)\n', '  File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py",
line 379, in marvinRequest\n    raise e\n', 'CloudstackAPIException: Execute cmd: createstoragepool
failed, due to: errorCode: 530, errorText:Failed to add data store: Failed to access storage
pool\n']
    ```


> Use Google Gson 2.3.1
> ---------------------
>
>                 Key: CLOUDSTACK-8708
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8708
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.6.0
>            Reporter: Wido den Hollander
>            Assignee: Daan Hoogland
>            Priority: Critical
>              Labels: gson, reflection
>
> Currently CloudStack uses Google GSON 1.7.2 which is from 30-Sep-2011.
> This is a outdated version. CLOUDSTACK-8677 (Call-Home feature) uses GSON 2.3.1 (20-Nov-2014)
which is not compatible with the current code.
> The roadmap of Gson shows that since 2.0 there is a change in casting: https://sites.google.com/site/gson/gson-roadmap
> "Gson 2.0 doesn’t support type adapters for primitive types."
> The "com.cloud.agent.transport.RequestTest" test in "core" fails with the new Gson version
and this leads back to "ArrayTypeAdaptor" which does the serializing and de-serializing of
JSON to Objects and back.
> Class<?> type = ((Class<?>)typeOfT).getComponentType();
> Fails, since getComponentType() doesn't return com.cloud.api.Command.
> This seems to be a Java Reflection issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message