cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-8708) Use Google Gson 2.3.1
Date Wed, 21 Oct 2015 00:23:27 GMT


ASF GitHub Bot commented on CLOUDSTACK-8708:

Github user rafaelweingartner commented on the pull request:
    @ DaanHoogland, 
    I ran the tests from my Windows environments, after I did some work arounds everything
started passing the tests. The fixes I did I created a PR into your branch.
    I used JDK 1.8.66, running from eclipse into a Windows 8 environment.

> Use Google Gson 2.3.1
> ---------------------
>                 Key: CLOUDSTACK-8708
>                 URL:
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.6.0
>            Reporter: Wido den Hollander
>            Assignee: Daan Hoogland
>            Priority: Critical
>              Labels: gson, reflection
> Currently CloudStack uses Google GSON 1.7.2 which is from 30-Sep-2011.
> This is a outdated version. CLOUDSTACK-8677 (Call-Home feature) uses GSON 2.3.1 (20-Nov-2014)
which is not compatible with the current code.
> The roadmap of Gson shows that since 2.0 there is a change in casting:
> "Gson 2.0 doesn’t support type adapters for primitive types."
> The "" test in "core" fails with the new Gson version
and this leads back to "ArrayTypeAdaptor" which does the serializing and de-serializing of
JSON to Objects and back.
> Class<?> type = ((Class<?>)typeOfT).getComponentType();
> Fails, since getComponentType() doesn't return
> This seems to be a Java Reflection issue.

This message was sent by Atlassian JIRA

View raw message