Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 18 Sep 2015 20:03:05 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12863317.1441958235000.15780.1442606585194@Atlassian.JIRA>
In-Reply-To: <JIRA.12863317.1441958235000@Atlassian.JIRA>
References: <JIRA.12863317.1441958235000@Atlassian.JIRA>
 <JIRA.12863317.1441958235233@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to
 work with Nuage VSP release 3.2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876258#comment-14876258 ] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39895038
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java ---
    @@ -0,0 +1,42 @@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +
    +package com.cloud.agent.api;
    +
    +import java.util.Map;
    +
    +public class UpdateNuageVspDeviceCommand extends Command {
    +
    +    Map<String, String> _parametersToBeUpdated;
    +
    +    public UpdateNuageVspDeviceCommand(Map<String, String> parametersToBeUpdated) {
    +        super();
    +        this._parametersToBeUpdated = parametersToBeUpdated;
    +    }
    +
    +    public Map<String, String> getParametersToBeUpdated() {
    +        return _parametersToBeUpdated;
    --- End diff --
    
    A defensive copy or the value wrapped in a call to  ``Collections.unmodifiableMap(...)``should be returned here in order to avoid unintended side effects by users of the return value.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)