Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 11 Sep 2015 12:56:47 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12862342.1441698032000.313648.1441976207413@Atlassian.JIRA>
In-Reply-To: <JIRA.12862342.1441698032000@Atlassian.JIRA>
References: <JIRA.12862342.1441698032000@Atlassian.JIRA>
 <JIRA.12862342.1441698032772@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8822) Replace Runnable by Callable
 in the com.cloud.utils.nio.Task class.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740744#comment-14740744 ] 

ASF subversion and git services commented on CLOUDSTACK-8822:
-------------------------------------------------------------

Commit 68bf049106959a13f74d42b07366da6e033e3446 in cloudstack's branch refs/heads/master from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=68bf049 ]

Merge pull request #805 from ekholabs/improvement/callable_CLOUDSTACK-8822

CLOUDSTACK-8822 - Replacing Runnable by CallableThat's the first part of the refactor, which will touch the ManagedContextRunnable and all its subclasses. However, in order to reduce impact, the first part comprises the Agent and Nio related classes (NioConnection, NioServer and NioClient).

* All the sub-classes were also updated according to the changes in the super-classes
* Improved exception handling
* There were also code formatting changes

Changes were structural and the NioTest covered them without need to modify the unit test.

This PR is quite extensive. Please, wait for the Test Report in order to proceed with further review.

ping @remibergsma @miguelaferreira @bhaisaab @karuturi @wido @DaanHoogland @borisroman @K0zka

Cheers,
Wilder

* pr/805:
  CLOUDSTACK-8822 - Replacing Runnable by Callable in the Taks and NioConnection classes

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>


> Replace Runnable by Callable in the com.cloud.utils.nio.Task class.
> -------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8822
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8822
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.6.0
>
>
> The current implementation of the Task abstract class swallows all the exceptions - everything extending Throwable - with only a WARN message.
> The best way to do that is by implementing Callable, which returns a value and also has a "throws Exception" in the call(0 method signature.
> This work will be structural, changing the hierarchy of Task and also its subclasses.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)