cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Fri, 18 Sep 2015 22:22:04 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876575#comment-14876575
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39906971
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
    @@ -262,15 +260,19 @@ public String getName() {
         public PingCommand getCurrentStatus(long id) {
             if ((_relativePath == null) || (_relativePath.isEmpty()) || (_cmsUserInfo ==
null) || (_cmsUserInfo.length == 0)) {
                 s_logger.error("Failed to ping to Nuage VSD");
    +            _shouldAudit = true;
                 return null;
             }
             try {
                 login();
             } catch (Exception e) {
                 s_logger.error("Failed to ping to Nuage VSD on " + _name + " as user " +
_cmsUserInfo[1] + " Exception " + e.getMessage());
    --- End diff --
    
    Pass the exception instance into the ``error`` call to provide the stack trace in the
log for debugging.
    
    Also, what if cmsUserInfo is null or has a length less than 1?  Checks need to be added
for these conditions to avoid an NPE or ``ArrayIndexOutOfBounds`` being thrown from this ``catch``
block.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message