cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Fri, 18 Sep 2015 21:21:06 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876454#comment-14876454
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39902380
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
    @@ -255,43 +319,22 @@ protected boolean canHandle(NetworkOffering offering, final NetworkType
networkT
         }
     
         @Override
    -    public boolean release(NicProfile nic, VirtualMachineProfile vm, String reservationId)
{
    -        long networkId = nic.getNetworkId();
    -        Network network = _networkDao.findById(networkId);
    -        s_logger.debug("Handling release() call back, which is called when a VM is stopped
or destroyed, to delete the VM with state " + vm.getVirtualMachine().getState()
    -                + " from netork " + network.getName());
    -        if (vm.getVirtualMachine().getState().equals(VirtualMachine.State.Stopping))
{
    -            try {
    -                HostVO nuageVspHost = getNuageVspHost(network.getPhysicalNetworkId());
    -                ReleaseVmVspCommand cmd = new ReleaseVmVspCommand(network.getUuid(),
vm.getUuid(), vm.getInstanceName());
    -                ReleaseVmVspAnswer answer = (ReleaseVmVspAnswer)_agentMgr.easySend(nuageVspHost.getId(),
cmd);
    -                if (answer == null || !answer.getResult()) {
    -                    s_logger.error("ReleaseVmNuageVspCommand for VM " + vm.getUuid()
+ " failed");
    -                    if ((null != answer) && (null != answer.getDetails())) {
    -                        s_logger.error(answer.getDetails());
    -                    }
    -                }
    -            } catch (InsufficientVirtualNetworkCapacityException e) {
    -                s_logger.debug("Handling release() call back. Failed to delete CS VM
" + vm.getInstanceName() + " in VSP. " + e.getMessage());
    -            }
    -        } else {
    -            s_logger.debug("Handling release() call back. VM " + vm.getInstanceName()
+ " is in " + vm.getVirtualMachine().getState() + " state. So, the CS VM is not deleted."
    -                    + " This could be a case where VM interface is deleted. deallocate()
call back should be called later");
    -        }
    -
    -        return super.release(nic, vm, reservationId);
    -    }
    -
    -    @Override
         @DB
         public void deallocate(Network network, NicProfile nic, VirtualMachineProfile vm)
{
    +        boolean lockedNetwork = lockNetworkForUserVm(network, vm);
    +        if (lockedNetwork) {
    +            s_logger.debug("Locked network " + network.getId() + " for deallocation of
user VM " + vm.getInstanceName());
    +        }
     
             try {
                 s_logger.debug("Handling deallocate() call back, which is called when a VM
is destroyed or interface is removed, " + "to delete VM Interface with IP "
    --- End diff --
    
    Wrap in a if (s_logger.isDebugEnabled()) { ... } block to avoid unnecessary pressure on
the string pool when debug logging is not enabled.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message