cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Fri, 18 Sep 2015 20:56:04 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876390#comment-14876390
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39900040
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -454,6 +563,80 @@ protected boolean applyACLRules(Network network, List<? extends
InternalIdentity
         }
     
         @Override
    +    public boolean applyNetworkACLs(Network config, List<? extends NetworkACLItem>
rules) throws ResourceUnavailableException {
    +        if (rules == null || rules.isEmpty()) {
    +            s_logger.debug("No rules to apply. So, delete all the existing ACL in VSP
from Subnet with uuid " + config.getUuid());
    +        } else {
    +            s_logger.debug("New rules has to applied. So, delete all the existing ACL
in VSP from Subnet with uuid " + config.getUuid());
    +        }
    +        if (rules != null) {
    +            s_logger.debug("Handling applyNetworkACLs for network " + config.getName()
+ " with " + rules.size() + " Network ACLs");
    +            applyACLRules(config, rules, true, null, rules.isEmpty());
    +        }
    +        return true;
    +    }
    +
    +    @Override
    +    public boolean implementVpc(Vpc vpc, DeployDestination dest, ReservationContext context)
throws ConcurrentOperationException, ResourceUnavailableException, InsufficientCapacityException
{
    +        return true;
    +    }
    +
    +    @Override
    +    public boolean shutdownVpc(Vpc vpc, ReservationContext context) throws ConcurrentOperationException,
ResourceUnavailableException {
    +        if (vpc.getState().equals(Vpc.State.Inactive)) {
    +            try {
    +                Domain vpcDomain = _domainDao.findById(vpc.getDomainId());
    +                HostVO nuageVspHost = getNuageVspHost(getPhysicalNetworkId(vpc.getZoneId()));
    +                String preConfiguredDomainTemplateName = _configDao.getValue(NuageVspManager.NuageVspVpcDomainTemplateName.key());
    +                ShutDownVpcVspCommand cmd = new ShutDownVpcVspCommand(vpcDomain.getUuid(),
vpc.getUuid(), preConfiguredDomainTemplateName);
    +                ShutDownVpcVspAnswer answer = (ShutDownVpcVspAnswer) _agentMgr.easySend(nuageVspHost.getId(),
cmd);
    +                if (answer == null || !answer.getResult()) {
    +                    s_logger.error("ShutDownVpcVspCommand for VPC " + vpc.getUuid() +
" failed");
    +                    if ((null != answer) && (null != answer.getDetails())) {
    +                        throw new ResourceUnavailableException(answer.getDetails(), Vpc.class,
vpc.getId());
    +                    }
    +                }
    +            } catch (Exception e) {
    +                s_logger.warn("Failed to destroy VPC in Vsp " + e.getMessage());
    --- End diff --
    
    Add the exception to the logging call to provide the stack trace for operational debugging.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message