cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Fri, 18 Sep 2015 20:43:04 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876355#comment-14876355
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39898871
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -196,6 +227,20 @@ public boolean implement(Network network, NetworkOffering offering,
DeployDestin
                 ResourceUnavailableException, InsufficientCapacityException {
             s_logger.debug("Entering NuageElement implement function for network " + network.getDisplayText()
+ " (state " + network.getState() + ")");
     
    +        if (network.getVpcId() != null) {
    +            List<NetworkACLItemVO> rules;
    +            if (network.getNetworkACLId() != null) {
    +                rules = _networkACLItemDao.listByACL(network.getNetworkACLId());
    +            } else {
    +                rules = new ArrayList<NetworkACLItemVO>(1);
    --- End diff --
    
    Why is a ``List`` of length 1 being created here?  If it should be empty, please use ``Collections.emptyList()``.
 Otherwise, it feels like a leaking abstraction.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message