cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Fri, 18 Sep 2015 20:20:04 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876302#comment-14876302
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39896434
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java
---
    @@ -17,38 +17,33 @@
     // under the License.
     //
     
    -package com.cloud.agent.api.guru;
    +package com.cloud.agent.api.sync;
     
     import com.cloud.agent.api.Command;
     
    -public class ReleaseVmVspCommand extends Command {
    +public class SyncNuageVspCmsIdCommand extends Command {
     
    -    String _networkUuid;
    -    String _vmUuid;
    -    String _vmInstanceName;
    +    public enum SyncType { AUDIT, AUDIT_ONLY, REGISTER, UNREGISTER }
     
    -    public ReleaseVmVspCommand(String networkUuid, String vmUuid, String vmInstanceName)
{
    -        super();
    -        this._networkUuid = networkUuid;
    -        this._vmUuid = vmUuid;
    -        this._vmInstanceName = vmInstanceName;
    -    }
    +    SyncType _syncType;
    +    String _nuageVspCmsId;
    --- End diff --
    
    Why aren't these attributes declared private? It doesn't appear to modified outside of
the constructor. Why aren't they declared final as well?


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message