cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
Date Fri, 18 Sep 2015 20:12:04 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876274#comment-14876274
] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39895754
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
    @@ -36,14 +37,26 @@
         String _vmUuid;
         String _vmUserName;
         String _vmUserDomainName;
    -
    -    public ReserveVmInterfaceVspCommand(String nicUuid, String nicMacAddress, String
networkUuid, boolean isL3Network, String vpcUuid, String networkDomainUuid,
    -            String networksAccountUuid, boolean isDomainRouter, String domainRouterIp,
String vmInstanceName, String vmUuid, String vmUserName, String vmUserDomainName) {
    +    boolean _useStaticIp;
    +    String _staticIp;
    +    String _staticNatIpUuid;
    +    String _staticNatIpAddress;
    +    boolean _isStaticNatIpAllocated;
    +    boolean _isOneToOneNat;
    +    String _staticNatVlanUuid;
    +    String _staticNatVlanGateway;
    +    String _staticNatVlanNetmask;
    +
    +    public ReserveVmInterfaceVspCommand(String nicUuid, String nicMacAddress, String
networkUuid, boolean isL3Network, boolean isSharedNetwork, String vpcUuid, String networkDomainUuid,
    +            String networksAccountUuid, boolean isDomainRouter, String domainRouterIp,
String vmInstanceName, String vmUuid, String vmUserName, String vmUserDomainName,
    +            boolean useStaticIp, String staticIp, String staticNatIpUuid, String staticNatIpAddress,
boolean isStaticNatIpAllocated, boolean isOneToOneNat, String staticNatVlanUuid,
    +            String staticNatVlanGateway, String staticNatVlanNetmask) {
    --- End diff --
    
    The number of parameters is extremely large -- creating a brittle interface and difficult
to comprehend client client. Please refactor to the Builder pattern.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message