cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-8822) Replace Runnable by Callable in the class.
Date Fri, 11 Sep 2015 12:22:46 GMT


ASF GitHub Bot commented on CLOUDSTACK-8822:

Github user wilderrodrigues commented on the pull request:
    Thanks, guys!
    @bhaisaab: I will change that and push in the second part of the refactor.
    Thanks again for a quick review! I will paste the tests results (still running because
I'm testing a lot) before merging.

> Replace Runnable by Callable in the class.
> -------------------------------------------------------------------
>                 Key: CLOUDSTACK-8822
>                 URL:
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.6.0
> The current implementation of the Task abstract class swallows all the exceptions - everything
extending Throwable - with only a WARN message.
> The best way to do that is by implementing Callable, which returns a value and also has
a "throws Exception" in the call(0 method signature.
> This work will be structural, changing the hierarchy of Task and also its subclasses.

This message was sent by Atlassian JIRA

View raw message