cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8822) Replace Runnable by Callable in the com.cloud.utils.nio.Task class.
Date Fri, 11 Sep 2015 12:09:46 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740668#comment-14740668
] 

ASF GitHub Bot commented on CLOUDSTACK-8822:
--------------------------------------------

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/805#issuecomment-139530031
  
    pending pull-analysis results; LGTM


> Replace Runnable by Callable in the com.cloud.utils.nio.Task class.
> -------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8822
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8822
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.6.0
>
>
> The current implementation of the Task abstract class swallows all the exceptions - everything
extending Throwable - with only a WARN message.
> The best way to do that is by implementing Callable, which returns a value and also has
a "throws Exception" in the call(0 method signature.
> This work will be structural, changing the hierarchy of Task and also its subclasses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message