cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8819) Virtual Template size is not correct when using S3 as image store.
Date Mon, 14 Sep 2015 08:53:45 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743175#comment-14743175
] 

ASF GitHub Bot commented on CLOUDSTACK-8819:
--------------------------------------------

Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/795#discussion_r39372256
  
    --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
    @@ -382,7 +424,7 @@ private String postDownload(String jobId) {
             if (extension.equals("iso")) {
                 templateName = jobs.get(jobId).getTmpltName().trim().replace(" ", "_");
             } else {
    -            templateName = java.util.UUID.nameUUIDFromBytes((jobs.get(jobId).getTmpltName()
+ System.currentTimeMillis()).getBytes()).toString();
    +            templateName = java.util.UUID.nameUUIDFromBytes((jobs.get(jobId).getTmpltName()
+ System.currentTimeMillis()).getBytes(Charset.forName("UTF-8"))).toString();
    --- End diff --
    
    Can you use StringUtils.getPreferredCharset()?


> Virtual Template size is not correct when using S3 as image store.
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8819
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8819
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Secondary Storage
>            Reporter: Boris Schrijver
>            Assignee: Boris Schrijver
>
> The virtual size is the same as the physical size of the template. See: https://github.com/apache/cloudstack/blob/master/services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java#L300



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message