Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8D90F187E0 for ; Wed, 19 Aug 2015 05:21:47 +0000 (UTC) Received: (qmail 38268 invoked by uid 500); 19 Aug 2015 05:21:47 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 38215 invoked by uid 500); 19 Aug 2015 05:21:47 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 38200 invoked by uid 500); 19 Aug 2015 05:21:46 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 38196 invoked by uid 99); 19 Aug 2015 05:21:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2015 05:21:46 +0000 Date: Wed, 19 Aug 2015 05:21:46 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8736) Refactor network code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702489#comment-14702489 ] ASF subversion and git services commented on CLOUDSTACK-8736: ------------------------------------------------------------- Commit c30ba1df0bd29cbb933bdeabcae3759111542f9e in cloudstack's branch refs/heads/master from [~boris@pcextreme.nl] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c30ba1d ] Refactored Nic.java for readability. Changed methodnames according to Nic.java refactor. Fixed NicVO.java due to regression from Nic.java refactor. Fixed VmWareGuru.java after Nic.java refactor. See issue CLOUDSTACK-8736 for ongoing effort to clean up network code. > Refactor network code > --------------------- > > Key: CLOUDSTACK-8736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8736 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Components: Network Controller, Network Devices > Reporter: Boris Schrijver > Assignee: Boris Schrijver > Priority: Minor > > Over the years after many code additions, changes and/or removals the network code has become obfuscated. Multiple getters/setters exist for the same variable, order and structure is missing, variable naming is not consistent, no clear difference exists between IPv4 and IPv6 code, and so on. > This ticket exist to be referenced to by PRs which includes refactors of network classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)