Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 4 Aug 2015 09:26:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12851325.1438673060000.365090.1438680364632@Atlassian.JIRA>
In-Reply-To: <JIRA.12851325.1438673060000@Atlassian.JIRA>
References: <JIRA.12851325.1438673060000@Atlassian.JIRA>
 <JIRA.12851325.1438673060238@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8704) Schedule restart of router VMs
 ahead of user VMs as part of HA
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653350#comment-14653350 ] 

ASF GitHub Bot commented on CLOUDSTACK-8704:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/656#discussion_r36170828
  
    --- Diff: server/test/com/cloud/ha/HighAvailabilityManagerImplTest.java ---
    @@ -113,12 +110,18 @@
         public void setup() throws IllegalArgumentException,
                 IllegalAccessException, NoSuchFieldException, SecurityException {
             highAvailabilityManager = new HighAvailabilityManagerImpl();
    -        for (Field injectField : HighAvailabilityManagerImpl.class
    -                .getDeclaredFields()) {
    +        for (Field injectField : HighAvailabilityManagerImpl.class.getDeclaredFields()) {
                 if (injectField.isAnnotationPresent(Inject.class)) {
                     injectField.setAccessible(true);
    -                injectField.set(highAvailabilityManager, this.getClass()
    -                        .getDeclaredField(injectField.getName()).get(this));
    +                injectField.set(highAvailabilityManager, this.getClass().getDeclaredField(injectField.getName()).get(this));
    +            } else if (injectField.getName().equals("_workers")) {
    --- End diff --
    
    Yes. "_workers" is the set of worker threads that perform HA related tasks in HighAvaiabilityManagerImpl class. As part of the test wakeupWorkers() methods get invoked which needs _workers to be initialized.


> Schedule restart of router VMs ahead of user VMs as part of HA
> --------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8704
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8704
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.5.0
>            Reporter: Koushik Das
>            Assignee: Koushik Das
>             Fix For: 4.6.0
>
>
> When a host is detected as Down, HA-enabled VMs running on it are scheduled for restart. There may be scenarios where both user VM and corresponding VR is on the same host and scheduled for restart. In such cases user VM restart will fail in initial attempts until VR is restarted. One way to reduce these occurrences is to schedule VR restart ahead of user VMs. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)