Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C6E118F25 for ; Mon, 3 Aug 2015 18:46:06 +0000 (UTC) Received: (qmail 85846 invoked by uid 500); 3 Aug 2015 18:46:05 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 85768 invoked by uid 500); 3 Aug 2015 18:46:05 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 85654 invoked by uid 500); 3 Aug 2015 18:46:05 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 85627 invoked by uid 99); 3 Aug 2015 18:46:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2015 18:46:05 +0000 Date: Mon, 3 Aug 2015 18:46:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8703) Cloudstack tries to re-download templates on S3 while they are already their. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652249#comment-14652249 ] ASF GitHub Bot commented on CLOUDSTACK-8703: -------------------------------------------- Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127366917 I cannot test the functionality myself right now, although it looks OK. @wido can you verify and give a final LGTM? I'll then merge it. @borisroman my only comment is your commit message. Please use 50 chars or less on the first line (as a title), then an empty line and finally any extra info or a description. Example: Fixed issue when listing directory on S3 CLOUDSTACK-8703: It would only return objectSummaries when the anwser from the S3 System was truncated. > Cloudstack tries to re-download templates on S3 while they are already their. > ----------------------------------------------------------------------------- > > Key: CLOUDSTACK-8703 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8703 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Secondary Storage > Affects Versions: 4.5.2 > Reporter: Boris Schrijver > Assignee: Boris Schrijver > Fix For: 4.6.0, 4.5.2 > > > When the management server restarts, reason doesn't matter, it will try to list all of the available templates on the secondary storage. To redownload them when they are missing. On S3, S3Utils listDirectory() will not return these because of a bug introduced in the following commit: debcbcc1454789936407583fe0aba8e158b16cad. So the management server will redownload them all. The listDirectory() method in S3Utils.java will only return objects when the anwser it receives from the S3 system is truncated. So listing smaller then the pagination limit will always return 0 obejcts. -- This message was sent by Atlassian JIRA (v6.3.4#6332)