cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8766) In zone based template listings, infinite scrolling pagination is broken
Date Thu, 27 Aug 2015 08:11:46 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716256#comment-14716256
] 

ASF GitHub Bot commented on CLOUDSTACK-8766:
--------------------------------------------

GitHub user bhaisaab opened a pull request:

    https://github.com/apache/cloudstack/pull/750

    CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/temp…

    …late listing
    
    Due to aggregation of templates and isos on the UI/client side, it could result
    that for each page we could end up having lesser templates/isos listed to have
    the scroll shown that triggers infinite scrolling. The fix is to use similar
    approach as in projects.js, to use the maximum pagesize of 500. In theory, there
    is still a chance if there are 500 zones with the same template being listed
    resulting in only one aggregated template which could cause the scroll to not
    get shown; but in practice I believe this fix should work for most users.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack 4.5-CLOUDSTACK-8766

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/750.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #750
    
----
commit 8a1cc7aac6f3d9a0a1686e2dae8dd12b74ed9cdd
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Date:   2015-08-27T07:01:04Z

    CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing
    
    Due to aggregation of templates and isos on the UI/client side, it could result
    that for each page we could end up having lesser templates/isos listed to have
    the scroll shown that triggers infinite scrolling. The fix is to use similar
    approach as in projects.js, to use the maximum pagesize of 500. In theory, there
    is still a chance if there are 500 zones with the same template being listed
    resulting in only one aggregated template which could cause the scroll to not
    get shown; but in practice I believe this fix should work for most users.
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

----


> In zone based template listings, infinite scrolling pagination is broken
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8766
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8766
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.5.0, 4.5.1, 4.5.2
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>            Priority: Minor
>             Fix For: 4.5.3, 4.6.0
>
>
> On the template page, when a template is select, goto Zones tab and scroll to list all
the templates. In case the number of zones are more than 20 there is an infinite scrolling/listing
issue as it does not paginate the result. The fix would be to use listViewDataProvider to
get pagination when requesting the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message