cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8749) KVM: link local route cleanup
Date Wed, 26 Aug 2015 07:31:45 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712651#comment-14712651
] 

ASF GitHub Bot commented on CLOUDSTACK-8749:
--------------------------------------------

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/735#discussion_r37953111
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
---
    @@ -286,7 +287,11 @@ private void deleteExitingLinkLocalRouteTable(String linkLocalBr)
{
                 String[] lines = parser.getLines().split("\\n");
                 for (String line : lines) {
                     String[] tokens = line.split(" ");
    -                if (!tokens[2].equalsIgnoreCase(linkLocalBr)) {
    +                if (tokens != null && tokens.length < 2) {
    +                    continue;
    +                }
    +                final String device = tokens[2];
    +                if (!Strings.isNullOrEmpty(device) && !device.equalsIgnoreCase(linkLocalBr))
{
    --- End diff --
    
    With respect to this specific code, I would like do this the next time we do a round of
refactoring, possibly factor such code to a util class that can be used as a general purpose
line parsing static method and add unit tests. For now, at least the code takes care of malformed
inputs. 


> KVM: link local route cleanup
> -----------------------------
>
>                 Key: CLOUDSTACK-8749
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8749
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: 4.5.3, 4.6.0
>
>
> The KVM agent attempts to delete link local interfaces whenever found, so they don't conflict with the system vm's link local route on cloud0, however it doesn't specify which device to delete the route for.
> The aim is to fix the edge case which (unlikely) can try to delete existing cloud0 routes/interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message