cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8727) API call listVirtualMachines returns same keypair
Date Wed, 12 Aug 2015 12:53:48 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693442#comment-14693442
] 

ASF GitHub Bot commented on CLOUDSTACK-8727:
--------------------------------------------

Github user sedukull commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/685#discussion_r36855422
  
    --- Diff: setup/db/db/schema-452to460.sql ---
    @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
             `cloud`.`user_vm_details` `custom_speed`  ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`)
and (`custom_speed`.`name` = 'CpuSpeed')))
                left join
             `cloud`.`user_vm_details` `custom_ram_size`  ON (((`custom_ram_size`.`vm_id`
= `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory')));
    +        delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id > s2.id and s1.public_key
= s2.public_key;
    +        ALTER TABLE ssh_keypairs ADD UNIQUE (fingerprint);
    --- End diff --
    
    Here, we added unique constraint on fingerprint column, but in previous one you deleted
the rows where public_key column values are same.
    
    The bug mentions that "previous" ones added with same names are deleted, here it seems
"id" is an auto  increment column and is deleting rows which are added "later", not the "previous"
ones.


> API call listVirtualMachines returns same keypair
> -------------------------------------------------
>
>                 Key: CLOUDSTACK-8727
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8727
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Kshitij Kansal
>
> If you register 2 SSH keypairs with the same public key then listVirtualMachines API
call will only return the first keypair. Although its a very rare case and generally don't
make much sense by registering the same key with different name, still it can be fixed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message