cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8727) API call listVirtualMachines returns same keypair
Date Fri, 28 Aug 2015 11:59:47 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718398#comment-14718398
] 

ASF GitHub Bot commented on CLOUDSTACK-8727:
--------------------------------------------

Github user sedukull commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/685#discussion_r38192659
  
    --- Diff: setup/db/db/schema-452to460.sql ---
    @@ -354,6 +354,10 @@ CREATE VIEW `cloud`.`user_vm_view` AS
                left join
             `cloud`.`user_vm_details` `custom_ram_size`  ON (((`custom_ram_size`.`vm_id`
= `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory')));
     
    +---Additional checks to ensure duplicate keys are not registered and remove the previously
stored duplicate keys.
    +DELETE `s1` FROM `ssh_keypairs` `s1`, `ssh_keypairs` `s2` WHERE `s1`.`id` > `s2`.`id`
AND `s1`.`public_key` = `s2`.`public_key` AND `s1`.`account_id` = `s2`.`account_id`;
    +ALTER TABLE `ssh_keypairs` ADD UNIQUE `unique_index`(`fingerprint`,`account_id`);
    --- End diff --
    
    May be name unique_index can be better renamed? By default UNIQUE constraint signifies
that. 


> API call listVirtualMachines returns same keypair
> -------------------------------------------------
>
>                 Key: CLOUDSTACK-8727
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8727
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Kshitij Kansal
>
> If you register 2 SSH keypairs with the same public key then listVirtualMachines API
call will only return the first keypair. Although its a very rare case and generally don't
make much sense by registering the same key with different name, still it can be fixed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message