cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-8720) Handle corner case in remove nic from vm
Date Mon, 10 Aug 2015 10:24:46 GMT


ASF GitHub Bot commented on CLOUDSTACK-8720:

Github user pavanb018 commented on the pull request:
    Looks Good to me. 
    Probably remove_nic might return an error if the NIC is not removed , but just wondering
if a check is needed in the below step , to validate that only 1 NIC exists for the VM by
listing nics after the remove nic operation? If you feel the check is redundant then leave
    #Try to remove nic 2 from vm1
    +        try:
    +            vm1.remove_nic(self.apiclient, self.nics[0].id)
    +        except Exception as e:
    +  "Failed to delete the nic from vm")
    +        return

> Handle corner case in remove nic from vm
> ----------------------------------------
>                 Key: CLOUDSTACK-8720
>                 URL:
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Sanjeev N
>            Assignee: Sanjeev N
> Adding test to cover the following scenario:
> 1) Deploy vm v1 in two networks say n1 and n2.
> 2) Check the IP of the nic in n2 say ip1
> 3) Deploy vm v2 in another network say n3 with same IP address as ip1 using 'deployVirtualMachine'
api with 'ipaddress' as one of the parameters.
> 4) Acquire public IP in n3 network.
> 5) Configure PF on the acquired IP
> 6) Choose destination vm as v2.
> 7) Try to remove nic of v1 in n2 network.
> Removing nic from v1 in n2 network should not be blocked because of the same ip addresses
from vms v1 and v2

This message was sent by Atlassian JIRA

View raw message