cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8379) add support to marvin to enable deployed zone based on the value provided in config file
Date Mon, 10 Aug 2015 08:47:45 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679809#comment-14679809
] 

ASF GitHub Bot commented on CLOUDSTACK-8379:
--------------------------------------------

Github user sanju1010 commented on the pull request:

    https://github.com/apache/cloudstack/pull/158#issuecomment-129368171
  
    -1
    Without changes it works fine, because if we don't specify the "enabled" attribute for
the zone in the config file, it will enable the zone by default. Even if the zone has the
attribute "enabled" without any value , then also we enable the zone. It anything other than
"true" then only we won't enable the zone.
    
    With @srikanteswartalluri changes this functionality will be broken because he is converting
the "None" to string in "getattr" method. So the following line will always have some string:
    enabled = enabled if enabled else 'true' 
    and if the zone object does not have the "enabled" attribute we are not calling the enableZone
which is not expected.


> add support to marvin to enable deployed zone based on the value provided in config file
> ----------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8379
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8379
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: marvin
>    Affects Versions: 4.6.0
>            Reporter: Srikanteswararao Talluri
>            Assignee: Srikanteswararao Talluri
>             Fix For: 4.6.0
>
>
> add support to marvin to enable deployed zone based on the value provided in config file
> if under zone section, if the 'enabled' element is not mentioned, then zone will be enabled
otherwise zone will be enabled/disabled based on value provided ('false' or 'true') for 'enabled'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message