Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E325918AAD for ; Wed, 22 Jul 2015 12:18:03 +0000 (UTC) Received: (qmail 39459 invoked by uid 500); 22 Jul 2015 12:17:05 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 39424 invoked by uid 500); 22 Jul 2015 12:17:05 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 39411 invoked by uid 500); 22 Jul 2015 12:17:05 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 39407 invoked by uid 99); 22 Jul 2015 12:17:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 12:17:05 +0000 Date: Wed, 22 Jul 2015 12:17:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8649) Register SSH keypair is broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636792#comment-14636792 ] ASF GitHub Bot commented on CLOUDSTACK-8649: -------------------------------------------- Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-123699898 @DaanHoogland double URL decoding was added during registerSSHKeyPair refactor. commit 968e71ad0e49088b5f2f022df29aec02b10a5ede Can you please check if this fix breaks any of that refactoring? LGTM otherwise. > Register SSH keypair is broken > ------------------------------ > > Key: CLOUDSTACK-8649 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8649 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Affects Versions: 4.5.0, 4.5.1 > Reporter: Lennert den Teuling > > It seems that when we upgraded form CS 4.3 to 4.5 the register SSH keypair functionality broke. > Registering keypairs work, but deployments with these newly registered keypair fails because they are not correctly put into the database. > It seems that at least half of the public key data is missing in the database. We have tried this with multiple keys, even with keys that worked before. Keys that were registered before the upgrade still work. > It is simple to reproduce, just register a SSH key and you will see the key will to be correctly put into the "ssh_keypairs" table and encrypting the VM password with the key will fail on deployment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)