Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Mon, 20 Jul 2015 08:31:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12845878.1437137933000.231691.1437381064894@Atlassian.JIRA>
In-Reply-To: <JIRA.12845878.1437137933000@Atlassian.JIRA>
References: <JIRA.12845878.1437137933000@Atlassian.JIRA>
 <JIRA.12845878.1437137933417@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8648) "Unable to get storage
 implementation" when copying template from NFS to S3
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8648?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D14633161#comment-14633161 ]=20

ASF GitHub Bot commented on CLOUDSTACK-8648:
--------------------------------------------

GitHub user wido opened a pull request:

    https://github.com/apache/cloudstack/pull/606

    CLOUDSTACK-8648: Do not configure the ImageFormat Processor when fetc=
=E2=80=A6

    =E2=80=A6hing filesize
   =20
    It will throw an exception and that's needed.
   =20
    Also, make the log show about which file we are talking about
   =20
    Signed-off-by: Wido den Hollander <wido@widodh.nl>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wido/cloudstack CLOUDSTACK-8648

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #606
   =20
----
commit 3fe8386853f40d05b6735f1b06e90ee48b7d9162
Author: Wido den Hollander <wido@widodh.nl>
Date:   2015-07-17T13:16:35Z

    CLOUDSTACK-8648: Do not configure the ImageFormat Processor when fetchi=
ng filesize
   =20
    It will throw an exception and that's needed.
   =20
    Also, make the log show about which file we are talking about
   =20
    Signed-off-by: Wido den Hollander <wido@widodh.nl>

----


> "Unable to get storage implementation" when copying template from NFS to =
S3
> -------------------------------------------------------------------------=
--
>
>                 Key: CLOUDSTACK-8648
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-864=
8
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: Secondary Storage
>    Affects Versions: Future, 4.5.2
>            Reporter: Wido den Hollander
>              Labels: qcow2, s3, secondary_storage
>             Fix For: Future
>
>
> In the SSVM this can be observed:
> 2015-07-17 12:12:56,675 WARN  [storage.resource.NfsSecondaryStorageResour=
ce] (agentRequest-Handler-11:null) Failed to get virtual size, returning fi=
le size instead:
> javax.naming.ConfigurationException: Unable to get storage implementation
> =09at com.cloud.storage.template.QCOW2Processor.configure(QCOW2Processor.=
java:95)
> =09at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.=
getVirtualSize(NfsSecondaryStorageResource.java:828)
> =09at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.=
copyFromNfsToS3(NfsSecondaryStorageResource.java:886)
> =09at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.=
copyFromNfsToImage(NfsSecondaryStorageResource.java:618)
> =09at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.=
execute(NfsSecondaryStorageResource.java:645)
> =09at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.=
executeRequest(NfsSecondaryStorageResource.java:233)
> =09at com.cloud.agent.Agent.processRequest(Agent.java:503)
> =09at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)
> =09at com.cloud.utils.nio.Task.run(Task.java:84)
> =09at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecuto=
r.java:1145)
> =09at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecut=
or.java:615)
> =09at java.lang.Thread.run(Thread.java:745)
> The problem is this:
> processor.configure("template processor", new HashMap<String, Object>());
> return processor.getVirtualSize(file);
> It confitures the processor with a empty HashMap, but the check in the pr=
ocessor is:
> public boolean configure(String name, Map<String, Object> params) throws =
ConfigurationException {
>     _storage =3D (StorageLayer)params.get(StorageLayer.InstanceConfigKey)=
;
>     if (_storage =3D=3D null) {
>         throw new ConfigurationException("Unable to get storage implement=
ation");
>     }
> Since the HashMap is empty null is returned and this exception is thrown.
> No need to configure the Processor as far as I can see.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)