Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 16 Jul 2015 10:51:05 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12845539.1437041472000.203921.1437043865008@Atlassian.JIRA>
In-Reply-To: <JIRA.12845539.1437041472000@Atlassian.JIRA>
References: <JIRA.12845539.1437041472000@Atlassian.JIRA>
 <JIRA.12845539.1437041472680@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8641) When calling "update
 hostpassword" API it throws NPE if the update_passwd_on_host if not
 informed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8641?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D14629547#comment-14629547 ]=20

ASF GitHub Bot commented on CLOUDSTACK-8641:
--------------------------------------------

GitHub user wilderrodrigues opened a pull request:

    https://github.com/apache/cloudstack/pull/596

    CLOUDSTACK-8641 - When calling "update hostpassword" API it throws NP=
=E2=80=A6

    =E2=80=A6E if the update_passwd_on_host if not informed
   =20
       - On getUpdatePasswdOnHost() method, if updatePasswdOnHost is null t=
hen return false.
   =20
    Apologies for the NPE. This will fix it.
   =20
    Output of command updating KVM host DB only:
   =20
    (local) =F0=9F=90=B5 > update hostpassword hostid=3D9ae1d93b-d09c-4e1c-=
94fa-9082e81cca26 username=3Droot password=3Dadmin123
    success =3D true
   =20
    @DaanHoogland @bhaisaab that's a quick one to review. :)
   =20
    Cheers,
    Wilder

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schubergphilis/cloudstack fix/CLOUDSTACK-=
8641

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #596
   =20
----
commit 5ecf24919fa6fb935578287587844d5463b9e76b
Author: wilderrodrigues <wrodrigues@schubergphilis.com>
Date:   2015-07-16T10:13:27Z

    CLOUDSTACK-8641 - When calling "update hostpassword" API it throws NPE =
if the update_passwd_on_host if not informed
   =20
       - On getUpdatePasswdOnHost() method, if updatePasswdOnHost is null t=
hen return false.

----


> When calling "update hostpassword" API it throws NPE if the update_passwd=
_on_host if not informed
> -------------------------------------------------------------------------=
------------------------
>
>                 Key: CLOUDSTACK-8641
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-864=
1
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: API
>    Affects Versions: 4.6.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>
> My apologies,
> I forgot to check the value of the Boolean attribute it's not informed. W=
as so eager to test it going all the way to the hosts that did not checking=
 the default value.
> This call fails:
> (local) =F0=9F=90=B5 > update hostpassword clusterid=3D53963278-f9d1-42d5=
-bab5-18c7ec466a0b username=3Droot password=3Dadmin123
> Error 530: None
> cserrorcode =3D 9999
> errorcode =3D 530
> When it should not.
> But this one passes:
> (local) =F0=9F=90=B5 > update hostpassword clusterid=3D53963278-f9d1-42d5=
-bab5-18c7ec466a0b username=3Droot password=3Dadmin123 update_passwd_on_hos=
t=3Dfalse
> success =3D true


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)