cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8641) When calling "update hostpassword" API it throws NPE if the update_passwd_on_host if not informed
Date Thu, 16 Jul 2015 10:51:05 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629547#comment-14629547
] 

ASF GitHub Bot commented on CLOUDSTACK-8641:
--------------------------------------------

GitHub user wilderrodrigues opened a pull request:

    https://github.com/apache/cloudstack/pull/596

    CLOUDSTACK-8641 - When calling "update hostpassword" API it throws NP…

    …E if the update_passwd_on_host if not informed
    
       - On getUpdatePasswdOnHost() method, if updatePasswdOnHost is null then return false.
    
    Apologies for the NPE. This will fix it.
    
    Output of command updating KVM host DB only:
    
    (local) 🐵 > update hostpassword hostid=9ae1d93b-d09c-4e1c-94fa-9082e81cca26 username=root
password=admin123
    success = true
    
    @DaanHoogland @bhaisaab that's a quick one to review. :)
    
    Cheers,
    Wilder

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schubergphilis/cloudstack fix/CLOUDSTACK-8641

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #596
    
----
commit 5ecf24919fa6fb935578287587844d5463b9e76b
Author: wilderrodrigues <wrodrigues@schubergphilis.com>
Date:   2015-07-16T10:13:27Z

    CLOUDSTACK-8641 - When calling "update hostpassword" API it throws NPE if the update_passwd_on_host
if not informed
    
       - On getUpdatePasswdOnHost() method, if updatePasswdOnHost is null then return false.

----


> When calling "update hostpassword" API it throws NPE if the update_passwd_on_host if
not informed
> -------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8641
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8641
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>    Affects Versions: 4.6.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>
> My apologies,
> I forgot to check the value of the Boolean attribute it's not informed. Was so eager
to test it going all the way to the hosts that did not checking the default value.
> This call fails:
> (local) 🐵 > update hostpassword clusterid=53963278-f9d1-42d5-bab5-18c7ec466a0b
username=root password=admin123
> Error 530: None
> cserrorcode = 9999
> errorcode = 530
> When it should not.
> But this one passes:
> (local) 🐵 > update hostpassword clusterid=53963278-f9d1-42d5-bab5-18c7ec466a0b
username=root password=admin123 update_passwd_on_host=false
> success = true



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message