cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8620) [Automation-lxc]skip test cases if rbd storage is not available in lxc setup
Date Thu, 09 Jul 2015 12:32:05 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620430#comment-14620430
] 

ASF GitHub Bot commented on CLOUDSTACK-8620:
--------------------------------------------

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/570#discussion_r34249648
  
    --- Diff: test/integration/component/test_ps_resize_volume.py ---
    @@ -48,59 +51,69 @@
                               RESOURCE_SECONDARY_STORAGE,
                               XEN_SERVER)
     
    +
     class TestResizeVolume(cloudstackTestCase):
     
         @classmethod
         def setUpClass(cls):
             cloudstackTestClient = super(TestResizeVolume,
    -                               cls).getClsTestClient()
    +                                     cls).getClsTestClient()
             cls.api_client = cloudstackTestClient.getApiClient()
    +        cls.hypervisor = cloudstackTestClient.getHypervisorInfo()
             # Fill services from the external config file
             cls.services = cloudstackTestClient.getParsedTestDataConfig()
             # Get Zone, Domain and templates
             cls.domain = get_domain(cls.api_client)
    -        cls.zone = get_zone(cls.api_client, cloudstackTestClient.getZoneForTests())
    +        cls.zone = get_zone(
    +            cls.api_client,
    +            cloudstackTestClient.getZoneForTests())
             cls.services["mode"] = cls.zone.networktype
    +        cls._cleanup = []
    +        cls.unsupportedStorageType = False
    +        if cls.hypervisor.lower() == 'lxc':
    +            if not find_storage_pool_type(cls.api_client, storagetype='rbd'):
    +                cls.unsupportedStorageType = True
    +                return
             cls.resourcetypemapping = {RESOURCE_PRIMARY_STORAGE: 10,
                                        RESOURCE_SECONDARY_STORAGE: 11}
     
    -
    -
             cls.template = get_template(
    -                            cls.api_client,
    -                            cls.zone.id,
    -                            cls.services["ostype"]
    -                            )
    +            cls.api_client,
    +            cls.zone.id,
    +            cls.services["ostype"]
    +        )
     
             cls.services["virtual_machine"]["zoneid"] = cls.zone.id
             cls.services["virtual_machine"]["template"] = cls.template.id
             cls.services["volume"]["zoneid"] = cls.zone.id
     
    -        cls._cleanup = []
             try:
                 cls.hypervisor = str(get_hypervisor_type(cls.api_client)).lower()
     
                 # Creating service offering with normal config
                 cls.service_offering = ServiceOffering.create(cls.api_client,
    -                                            cls.services["service_offering"])
    +                                                          cls.services["\
    --- End diff --
    
    this looks strange. are you sure you want to break the line within a string-literal?


> [Automation-lxc]skip test cases if rbd storage is not available in lxc setup 
> -----------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8620
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8620
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>    Affects Versions: 4.5.1
>            Reporter: prashant kumar mishra
>            Assignee: prashant kumar mishra
>             Fix For: 4.5.1
>
>
> For data volume rbd storage is required  many test cases like volume creation , vm deployement
with data disks are failing due to no suitable storage pool found .
> skip the test case if rbd storage is not available



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message