cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
Date Fri, 17 Jul 2015 11:07:05 GMT


ASF GitHub Bot commented on CLOUDSTACK-8605:

Github user wido commented on the pull request:
    Code-wise I'm not to happy. There are all kinds of assumptions about paths. mkisofs for
example always being there in /usr/bin.
    Using /tmp for temporary directories, who says that /tmp is big enough on every system?
Always using /var/lib/libvirt to place the ISO? Why not fetch the local storage pool and figure
out what the path is.
    It's not guaranteerd that it will be /var/lib/libvirt/images on all systems.
    Imho there are to many assumptions in the code which makes it fragile.

> KVM: Config Drive and getVmIp support
> -------------------------------------
>                 Key: CLOUDSTACK-8605
>                 URL:
>             Project: CloudStack
>          Issue Type: Sub-task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: 4.6.0
>            Reporter: Kishan Kavala
>            Assignee: Kishan Kavala
>             Fix For: 4.6.0
> Add support for 
> - creating config drive
> - Fetch IP from guest Vm which is assigned by external DHCP

This message was sent by Atlassian JIRA

View raw message