cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-8551) Findbugs warning in and
Date Fri, 12 Jun 2015 08:58:02 GMT


ASF GitHub Bot commented on CLOUDSTACK-8551:

Github user karuturi commented on the pull request:
    Thanks for the review Daan. Will merge it now.

> Findbugs warning in and
> -------------------------------------------------------------------------
>                 Key: CLOUDSTACK-8551
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.3.0, 4.4.0, 4.5.1
>            Reporter: Rajani Karuturi
>            Assignee: Rajani Karuturi
>              Labels: ldap
>             Fix For: 4.6.0
> Invocation of toString on org.bouncycastle.util.encoders.Base64.encode(byte[]) in org.apache.cloudstack.api.command.LdapCreateAccountCmd.generatePassword()
> The code invokes toString on an array, which will generate a fairly useless result such
as [C@16f0472. Consider using Arrays.toString to convert the array into a readable String
that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12. 
>, DM_DEFAULT_ENCODING, Priority: High
> Found reliance on default encoding in org.apache.cloudstack.api.command.LdapImportUsersCmd.generatePassword():
new String(byte[])
> Found a call to a method which will perform a byte to String (or String to byte) conversion,
and will assume that the default platform encoding is suitable. This will cause the application
behaviour to vary between platforms. Use an alternative API and specify a charset name or
Charset object explicitly. 

This message was sent by Atlassian JIRA

View raw message