cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8542) Correct the tests in test_vpc_on_host_maintenance.py and remove invalid tests
Date Fri, 05 Jun 2015 11:57:01 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574378#comment-14574378
] 

ASF GitHub Bot commented on CLOUDSTACK-8542:
--------------------------------------------

GitHub user gauravaradhye opened a pull request:

    https://github.com/apache/cloudstack/pull/360

    CLOUDSTACK-8542: Correcting test case in test_vpc_on_host_maintenance.py

    The test in the test suite is checking that when the hosts are in maintenance state, then
VPC created with start=False parameter should be in inactive state. However, this is incorrect.
    
    VPC is in inactive state only after it is deleted. Hence the state of the VPC created
when the hosts are in maintenance state is Enabled only.
    
    Further, the VPC won't be deleted by any cleanup threads because it is in enabled state
and not in inactive state. Remove the test case which asserts that VPC should be removed after
cleanup interval.
    
    Other changes:
    Removed hard-coded services dict from the test case. Instead the test case will use the
dict located at /marvin/config/test_data.py which is common for all test cases.
    
    Logs:
    Test VPC when host is in maintenance mode ... === TestName: test_01_create_vpc_host_maintenance
| Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 189.881s
    
    OK

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gauravaradhye/cloudstack 8542

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #360
    
----
commit 844a3bc167cdaa2e6b82444e587d9547f146c0e4
Author: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
Date:   2015-06-05T09:05:56Z

    CLOUDSTACK-8542: Correcting test case in test_vpc_on_host_maintenance.py

----


> Correct the tests in test_vpc_on_host_maintenance.py and remove invalid tests
> -----------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8542
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8542
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>    Affects Versions: 4.6.0
>            Reporter: Gaurav Aradhye
>            Assignee: Gaurav Aradhye
>              Labels: automation
>             Fix For: 4.6.0
>
>
> The test in the test suite is checking that when the hosts are in maintenance state,
then VPC created with start=False parameter should be in inactive state. However, this is
not correct.
> VPC is in inactive state only after it is deleted. Hence the state of the VPC created
when the hosts are in maintenance state is Enabled only.
> Further, the VPC won't be deleted by any cleanup threads because it is in enabled state
and not in inactive state. Remove the test case which asserts that VPC should be removed after
cleanup interval.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message