Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7820717AF1 for ; Wed, 20 May 2015 14:10:00 +0000 (UTC) Received: (qmail 56222 invoked by uid 500); 20 May 2015 14:10:00 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 56180 invoked by uid 500); 20 May 2015 14:10:00 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 56169 invoked by uid 500); 20 May 2015 14:10:00 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 56166 invoked by uid 99); 20 May 2015 14:10:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 May 2015 14:10:00 +0000 Date: Wed, 20 May 2015 14:10:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8486) Refactoring LibVirt (KVM) Hypervisor Plugin MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552355#comment-14552355 ] ASF GitHub Bot commented on CLOUDSTACK-8486: -------------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/270 > Refactoring LibVirt (KVM) Hypervisor Plugin > ------------------------------------------- > > Key: CLOUDSTACK-8486 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8486 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Components: KVM > Affects Versions: 4.5.0 > Reporter: Wilder Rodrigues > Assignee: Wilder Rodrigues > Fix For: 4.6.0 > > > The main goal behind this refactor is to reduce the amount of code in the LibvirtComputingResource class and also all the nested IFs that it has in the executeRequest() method (67 in total). > The same approach used in the CitrixResourceBase refactoring will be applied here. > In addition, for each method extracted from the LibvirtComputingResource into a wrapper, a unit test will be created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)