Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Wed, 1 Apr 2015 07:18:52 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12787272.1427871704000.89766.1427872732812@Atlassian.JIRA>
In-Reply-To: <JIRA.12787272.1427871704000@Atlassian.JIRA>
References: <JIRA.12787272.1427871704000@Atlassian.JIRA>
 <JIRA.12787272.1427871704558@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-8356) Mention netaddr module as
 dependency in marvin setup.py file as it is used across test cases
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390126#comment-14390126 ] 

ASF GitHub Bot commented on CLOUDSTACK-8356:
--------------------------------------------

GitHub user gauravaradhye opened a pull request:

    https://github.com/apache/cloudstack/pull/138

    CLOUDSTACK-8356: Mentioning netaddr module in setup.py in marvin as it is used across test cases

    The netaddr module is used in various test cases but it is not mentioned in setup.py file. Test cases will fail with import error if the module is absent on user machine even when marvin is installed.
    
    Mentioning the netaddr module in setup.py file so it is installed with marvin.
    
    Tested the change with packaging new marvin tar with the change and installing marvin with pip on a machine which did not have netaddr module. It downloaded and installed it automatically.
    
    pip install Marvin-4.5.1.0.tar.gz
    Unpacking ./Marvin-4.5.1.0.tar.gz
    Running setup.py (path:/tmp/pip-D49qWR-build/setup.py) egg_info for package from file:///root/Marvin-4.5.1.0/dist/Marvin-4.5.1.0.tar.gz
        warning: no files found matching '*.txt' under directory 'docs'
    Requirement already satisfied (use --upgrade to upgrade): mysql-connector-python>=1.1.6 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0)
    Requirement already satisfied (use --upgrade to upgrade): requests>=2.2.1 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0)
    Requirement already satisfied (use --upgrade to upgrade): paramiko>=1.13.0 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0)
    Requirement already satisfied (use --upgrade to upgrade): nose>=1.3.3 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0)
    Requirement already satisfied (use --upgrade to upgrade): ddt>=0.4.0 in /usr/lib/python2.6/site-packages (from Marvin==4.5.1.0)
    Downloading/unpacking netaddr>=0.7.11 (from Marvin==4.5.1.0)
      Downloading netaddr-0.7.14-py2.py3-none-any.whl (1.5MB): 1.5MB downloaded
    Installing collected packages: netaddr, Marvin
      Found existing installation: Marvin 0.1.0
        Uninstalling Marvin:
          Successfully uninstalled Marvin
      Running setup.py install for Marvin
        warning: no files found matching '*.txt' under directory 'docs'
        Installing marvincli script to /usr/bin
    Successfully installed netaddr Marvin
    Cleaning up...


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gauravaradhye/cloudstack 8356

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
    
----
commit 692a56e86803ef8b8bcb20c37764a31da091f510
Author: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
Date:   2015-04-01T07:09:47Z

    CLOUDSTACK-8356: Mentioning netaddr module in setup.py in marvin as it is used across test cases

----


> Mention netaddr module as dependency in marvin setup.py file as it is used across test cases
> --------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8356
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8356
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>    Affects Versions: Future
>            Reporter: Gaurav Aradhye
>            Assignee: Gaurav Aradhye
>              Labels: automation
>             Fix For: Future
>
>
> The netaddr module is used in various test cases but it is not mentioned in setup.py file. Test cases will fail with import error if the module is absent on user machine even when marvin is installed.
> Mentioning the netaddr module in setup.py file so it is installed with marvin.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)