cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8377) Marvin - base library - Fix list function for PhysicalNetwork class
Date Sat, 11 Apr 2015 10:40:13 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490909#comment-14490909
] 

ASF GitHub Bot commented on CLOUDSTACK-8377:
--------------------------------------------

GitHub user gauravaradhye opened a pull request:

    https://github.com/apache/cloudstack/pull/156

    CLOUDSTACK-8377: Marvin - base library - Fix list method for PhysicalNetwork class

    Removed map() from list method for PhysicalNetwork class.
    map() function works only when the second argument is a list. However, when there are
no physical networks in the zone, the API will return None and it will be passed as second
argument to map. It will fail in this case.
    
    Instead return the API response as it is. No need to use map().
    
    Tested.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gauravaradhye/cloudstack 8377

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 1a2746ed00e60d32231342b7abb39ea71fa67282
Author: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
Date:   2015-04-11T10:36:31Z

    CLOUDSTACK-8377: Marvin - base library - Fix list method for PhysicalNetwork class

----


> Marvin - base library - Fix list function for PhysicalNetwork class
> -------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8377
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8377
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>    Affects Versions: Future
>            Reporter: Gaurav Aradhye
>            Assignee: Gaurav Aradhye
>              Labels: automation
>             Fix For: Future
>
>
> Remove map function from list function in PhysicalNetwork class. The map function fails
when listPhysicalNetwork API returns None.
> Instead return the response as it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message