cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8278) Usage test path - Correct code flow in case the usage job timing is not to be set through test case
Date Tue, 24 Mar 2015 04:50:53 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377277#comment-14377277
] 

ASF GitHub Bot commented on CLOUDSTACK-8278:
--------------------------------------------

GitHub user gauravaradhye opened a pull request:

    https://github.com/apache/cloudstack/pull/127

    CLOUDSTACK-8278: Usage test path - Correct code flow in case the usage job configuration
is not to be set through test case

    The flag "setUsageConfigurationThroughTestCase" dictates whether we should set the usage
related config from test case itself (And restart the management server and usage server in
the process) or not.
    
    When the flag is False (When we don't want to disrupt other test cases and/or usage server/job
is already configured), then it should be ensured that the code is not broken anywhere.
    
    Currently the value of the flag is True, hence by default test case sets the usage global
setting values and restarts the management and usage server in the process. This can disrupt
other test case execution going on in parallel. So making the default value of the flag to
False and also making changes in the test case to ensure test case works correctly in this
case.
    
    If we are running the test suite on a separate setup and want to set global settings related
to usage through test case itself, then we can turn the flag to True whenever required before
the run.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gauravaradhye/cloudstack 8278

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 5ad31da1dc751e0a358f1657dee98c5bd3b1b7c6
Author: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
Date:   2015-02-23T10:48:16Z

    CLOUDSTACK-8278: Usage test path - Correct code flow in case the usage job configuration
is not to be set through test case

commit 71653dc1388f431e9bb4e7758cc43a813902e12b
Author: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
Date:   2015-03-24T04:46:01Z

    Setting the default value of flag to False

----


> Usage test path - Correct code flow in case the usage job timing is not to be set through
test case
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8278
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8278
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation
>    Affects Versions: Future
>            Reporter: Gaurav Aradhye
>            Assignee: Gaurav Aradhye
>              Labels: automation
>             Fix For: Future
>
>
> The flag "setUsageConfigurationThroughTestCase" dictates whether we should set the usage
related config from test case itself (And restart the management server and usage server in
the process) or not.
> When the flag is False (When we don't want to disrupt other test cases and/or usage server/job
is already configured), then it should be ensured that the code is broken anywhere. Set the
current date to cls.curDate variable in this case to avoid code break.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message