cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8154) Fix typo in response name string: there is an extra 's'
Date Wed, 14 Jan 2015 11:00:36 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276784#comment-14276784
] 

ASF GitHub Bot commented on CLOUDSTACK-8154:
--------------------------------------------

Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/63#issuecomment-69900395
  
    Tested with CloudMonkey/Marvin, most sane clients should not break who search for objects
in a "xyzresponse" key. This also fixes the UI so we're good.
    
    Google search resulted 8 places where "deleteisosresponse" was used. Such fixes have been
done in the past. The impact is low, also because it's an async api.
    
    Response before;
    { "deleteisosresponse" : {"jobid":"aef086a9-ceb6-4af1-9b01-44a130dc6a16"} }
    
    Response after the fix;
    { "deleteisoresponse" : {"jobid":"0fd02b7f-0a14-4ef2-8dc5-932a9ee30004"} }


> Fix typo in response name string: there is an extra 's'
> -------------------------------------------------------
>
>                 Key: CLOUDSTACK-8154
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8154
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: René Moser
>
> https://github.com/apache/cloudstack/blob/master/api/src/org/apache/cloudstack/api/command/user/iso/DeleteIsoCmd.java#L41

> The correct string should be deleteisoresponse.
> Will also create UI issue to handle the change in the response.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message