Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 752891080C for ; Tue, 18 Nov 2014 08:52:36 +0000 (UTC) Received: (qmail 1345 invoked by uid 500); 18 Nov 2014 08:52:36 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 1324 invoked by uid 500); 18 Nov 2014 08:52:35 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 1311 invoked by uid 500); 18 Nov 2014 08:52:35 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 1308 invoked by uid 99); 18 Nov 2014 08:52:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Nov 2014 08:52:35 +0000 Date: Tue, 18 Nov 2014 08:52:35 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-7931) Setting Null for global network throttling params doesn't trigger suitable error, fails silently MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-7931?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D14215930#comment-14215930 ]=20 ASF subversion and git services commented on CLOUDSTACK-7931: ------------------------------------------------------------- Commit 8307dd9105cdb70a0fe09c059bacfcec43a29024 in cloudstack's branch refs= /heads/4.5 from [~anshulg] [ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3D8307dd9 ] CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for gl= obal settings which are of type integer and float This closes #41 > Setting Null for global network throttling params doesn't trigger suitabl= e error, fails silently > -------------------------------------------------------------------------= ----------------------- > > Key: CLOUDSTACK-7931 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-793= 1 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Reporter: Anshul Gangwar > Assignee: Anshul Gangwar > Priority: Critical > Fix For: 4.5.0 > > > Set global configs network.throttling.rate and vm.network.throttling.rate= to NULL value. > Then launch VM in a new network > Result > =3D=3D=3D=3D=3D > VM fails to launch but it fails without any ERROR logs or suitable except= ions. > A corresponding INFO log seems to have nothing but "null" > Generally, for few global configs NULL is an acceptable value in some cas= es. If this is not the case, then we should not allow to set such a value f= or the config. The API should error out suitably. This is one issue. > Further, it should throw an appropriate error when the deploy VM fails to= design network. The error in this case is not handled suitably and there's= nothing in ERROR logs as well. > Looking at the below logs, it's impossible to figure out the reason for t= he failure of deploy VM. So at some point, if a user inadvertently sets it = to NULL, neither does the updateConfiguration API result in error nor does = the deployVirtualMachine throw a suitable error. > Here's the log: > 2014-11-13 13:29:15,584 DEBUG [c.c.a.ApiServlet] (catalina-exec-18:ctx-28= 5ce7d9) =3D=3D=3DSTART=3D=3D=3D 10.144.7.5 =E2=80=93 GET command=3DcreateNe= twork&response=3Djson&sessionkey=3D6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOf= feringId=3De8746c6b-e945-4084-9290-37cea253e262&name=3Dnewtest1&displayText= =3Dnewtest1&zoneId=3Db642a92a-3480-4818-99bf-6546a28df624&_=3D1415866216789 > 2014-11-13 13:29:15,617 DEBUG [o.a.c.n.c.m.ContrailGuru] (catalina-exec-1= 8:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,617 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] (catalina= -exec-18:ctx-285ce7d9 ctx-5245ccb7) design called > 2014-11-13 13:29:15,618 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] (catalina= -exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network, the ph= ysical isolation type is not MIDO > 2014-11-13 13:29:15,619 DEBUG [c.c.n.g.NiciraNvpGuestNetworkGuru] (catali= na-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,620 DEBUG [o.a.c.n.o.OpendaylightGuestNetworkGuru] (c= atalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,621 DEBUG [c.c.n.g.OvsGuestNetworkGuru] (catalina-exe= c-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,644 DEBUG [o.a.c.n.g.SspGuestNetworkGuru] (catalina-e= xec-18:ctx-285ce7d9 ctx-5245ccb7) SSP not configured to be active > 2014-11-13 13:29:15,645 DEBUG [c.c.n.g.BrocadeVcsGuestNetworkGuru] (catal= ina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,646 DEBUG [c.c.n.g.NuageVspGuestNetworkGuru] (catalin= a-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,648 DEBUG [o.a.c.e.o.NetworkOrchestrator] (catalina-e= xec-18:ctx-285ce7d9 ctx-5245ccb7) Releasing lock for Acct[467a4f66-698f-11e= 4-be18-42407779c24b-admin] > 2014-11-13 13:29:15,688 DEBUG [c.c.a.ApiServlet] (catalina-exec-18:ctx-28= 5ce7d9 ctx-5245ccb7) =3D=3D=3DEND=3D=3D=3D 10.144.7.5 =E2=80=93 GET command= =3DcreateNetwork&response=3Djson&sessionkey=3D6ZKk3l0f4pdKU1yfDZxwF31YgCM%3= D&networkOfferingId=3De8746c6b-e945-4084-9290-37cea253e262&name=3Dnewtest1&= displayText=3Dnewtest1&zoneId=3Db642a92a-3480-4818-99bf-6546a28df624&_=3D14= 15866216789 > 2014-11-13 13:29:15,727 DEBUG [c.c.a.ApiServlet] (catalina-exec-9:ctx-547= 81545) =3D=3D=3DSTART=3D=3D=3D 10.144.7.5 =E2=80=93 GET command=3DdeployVir= tualMachine&response=3Djson&sessionkey=3D6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&zon= eid=3Db642a92a-3480-4818-99bf-6546a28df624&templateid=3Df7df5ef0-698e-11e4-= be18-42407779c24b&hypervisor=3DXenServer&serviceofferingid=3D04840780-04d0-= 4b41-847a-dda08ad460f4&iptonetworklist%5B0%5D.networkid=3Dc0e24f7a-fe03-4a3= b-a11e-ab29150b803b&displayname=3Dthrottlingvm1&name=3Dthrottlingvm1&_=3D14= 15866216945 > 2014-11-13 13:29:15,753 DEBUG [c.c.n.NetworkModelImpl] (catalina-exec-9:c= tx-54781545 ctx-e87f4810) Service SecurityGroup is not supported in the net= work id=3D209 > 2014-11-13 13:29:15,777 DEBUG [c.c.v.UserVmManagerImpl] (catalina-exec-9:= ctx-54781545 ctx-e87f4810) Allocating in the DB for vm > 2014-11-13 13:29:15,793 DEBUG [c.c.v.VirtualMachineManagerImpl] (catalina= -exec-9:ctx-54781545 ctx-e87f4810) Allocating entries for VM: VM[User|i-2-2= 2-VM] > 2014-11-13 13:29:15,794 DEBUG [c.c.v.VirtualMachineManagerImpl] (catalina= -exec-9:ctx-54781545 ctx-e87f4810) Allocating nics for VM[User|i-2-22-VM] > 2014-11-13 13:29:15,794 DEBUG [o.a.c.e.o.NetworkOrchestrator] (catalina-e= xec-9:ctx-54781545 ctx-e87f4810) Allocating nic for vm VM[User|i-2-22-VM] i= n network Ntwk[209|Guest|8] with requested profile NicProfile[0-0-null-null= -null > 2014-11-13 13:29:15,808 DEBUG [c.c.u.d.T.Transaction] (catalina-exec-9:ct= x-54781545 ctx-e87f4810) Rolling back the transaction: Time =3D 41 Name =3D= catalina-exec-9; called by -TransactionLegacy.rollback:902-TransactionLega= cy.removeUpTo:845-TransactionLegacy.close:669-Transaction.execute:49-Networ= kOrchestrator.allocate:711-VirtualMachineManagerImpl$1.doInTransactionWitho= utResult:396-TransactionCallbackWithExceptionNoReturn.doInTransaction:25-Tr= ansactionCallbackWithExceptionNoReturn.doInTransaction:21-Transaction.execu= te:45-VirtualMachineManagerImpl.allocate:388-CloudOrchestrator.createVirtua= lMachine:236-UserVmManagerImpl$3.doInTransaction:3119 > 2014-11-13 13:29:15,817 DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Ha= ndler-3:null) SeqA 2-28534: Processing Seq 2-28534: { Cmd , MgmtId: -1, via= : 2, Ver: v1, Flags: 11, [{"com.cloud.agent.api.ConsoleProxyLoadReportComma= nd":{"_proxyVmId":1,"_loadInfo":" > {\n \"connections\": []\n} > ","wait":0}}] } > 2014-11-13 13:29:15,819 INFO [c.c.a.ApiServer] (catalina-exec-9:ctx-54781= 545 ctx-e87f4810) null > 2014-11-13 13:29:15,821 DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Ha= ndler-3:null) SeqA 2-28534: Sending Seq 2-28534: { Ans: , MgmtId: 728446498= 08459, via: 2, Ver: v1, Flags: 100010, [{"com.cloud.agent.api.AgentControlA= nswer":{"result":true,"wait":0}}] } > 2014-11-13 13:29:15,822 DEBUG [c.c.a.ApiServlet] (catalina-exec-9:ctx-547= 81545 ctx-e87f4810) =3D=3D=3DEND=3D=3D=3D 10.144.7.5 =E2=80=93 GET command= =3DdeployVirtualMachine&response=3Djson&sessionkey=3D6ZKk3l0f4pdKU1yfDZxwF3= 1YgCM%3D&zoneid=3Db642a92a-3480-4818-99bf-6546a28df624&templateid=3Df7df5ef= 0-698e-11e4-be18-42407779c24b&hypervisor=3DXenServer&serviceofferingid=3D04= 840780-04d0-4b41-847a-dda08ad460f4&iptonetworklist%5B0%5D.networkid=3Dc0e24= f7a-fe03-4a3b-a11e-ab29150b803b&displayname=3Dthrottlingvm1&name=3Dthrottli= ngvm1&_=3D1415866216945 > 2014-11-13 13:29:20,818 DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Ha= ndler-4:null) SeqA 2-28535: Processing Seq 2-28535: { Cmd , MgmtId: -1, via= : 2, Ver: v1, Flags: 11, [{"com.cloud.agent.api.ConsoleProxyLoadReportComma= nd":{"_proxyVmId":1,"_loadInfo":" > {\n \"connections\": []\n} > ","wait":0}}] } > 2014-11-13 13:29:20,823 DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Ha= ndler-4:null) SeqA 2-28535: Sending Seq 2-28535: { Ans: , MgmtId: 728446498= 08459, via: 2, Ver: v1, Flags: 100010, [{"com.cloud.agent.api.AgentControlA= nswer":{"result":true,"wait":0}}] } > 2014-11-13 13:29:25,159 DEBUG [c.c.a.AlertManagerImpl] (CapacityChecker:c= tx-632a5f21) Running Capacity Checker ... > 2014-11-13 13:29:25,159 DEBUG [c.c.a.AlertManagerImpl] (CapacityChecker:c= tx-632a5f21) recalculating system capacity > 2014-11-13 13:29:25,159 DEBUG [c.c.a.AlertManagerImpl] (CapacityChecker:c= tx-632a5f21) Executing cpu/ram capacity update > 2014-11-13 13:29:25,170 DEBUG [c.c.c.CapacityManagerImpl] (CapacityChecke= r:ctx-632a5f21) Found 2 VMs on host 1 > 2014-11-13 13:29:25,173 DEBUG [c.c.c.CapacityManagerImpl] (CapacityChecke= r:ctx-632a5f21) Found 0 VM, not running on host 1 > 2014-11-13 13:29:25,174 DEBUG [c.c.c.CapacityManagerImpl] (CapacityChecke= r:ctx-632a5f21) No need to calibrate cpu capacity, host:1 usedCpu: 1000 res= ervedCpu: 0 > 2014-11-13 13:29:25,174 DEBUG [c.c.c.CapacityManagerImpl] (CapacityChecke= r:ctx-632a5f21) No need to calibrate memory capacity, host:1 usedMem: 16106= 12736 reservedMem: 0 > 2014-11-13 13:29:25,188 DEBUG [c.c.c.CapacityManagerImpl] (CapacityChecke= r:ctx-632a5f21) Found 2 VMs on host 4 > 2014-11-13 13:29:25,194 DEBUG [c.c.c.CapacityManagerImpl] (CapacityChecke= r:ctx-632a5f21) Found 0 VM, not running on host 4 > 2014-11-13 13:29:25,196 DEBUG [c.c.c.CapacityManagerImpl] (CapacityChecke= r:ctx-632a5f21) No need to calibrate cpu capacity, host:4 usedCpu: 4500 res= ervedCpu: 0 > 2014-11-13 13:29:25,196 DEBUG [c.c.c.CapacityManagerImpl] (CapacityChecke= r:ctx-632a5f21) No need to calibrate memory capacity, host:4 usedMem: 16106= 12736 reservedMem: 0 > 2014-11-13 13:29:25,201 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (Host= ReservationReleaseChecker:ctx-d94e4eee) Checking if any host reservation ca= n be released ... > 2014-11-13 13:29:25,204 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobM= gr-Heartbeat-1:ctx-ad293aec) Begin cleanup expired async-jobs > 2014-11-13 13:29:25,229 DEBUG [c.c.a.AlertManagerImpl] (CapacityChecker:c= tx-632a5f21) Done executing cpu/ram capacity update > 2014-11-13 13:29:25,229 DEBUG [c.c.a.AlertManagerImpl] (CapacityChecker:c= tx-632a5f21) Executing storage capacity update -- This message was sent by Atlassian JIRA (v6.3.4#6332)