cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
Date Tue, 18 Nov 2014 06:48:34 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215785#comment-14215785
] 

ASF GitHub Bot commented on CLOUDSTACK-7932:
--------------------------------------------

Github user anshul1886 commented on the pull request:

    https://github.com/apache/cloudstack/pull/39#issuecomment-63429460
  
    Actually null has different meaning than false. False means that vm is not alive while
null means it cannot be determined whether it is alive or not. 
    
    This is existing functionality for all hypervisor investigators so it doesn't make sense
to write unit tests for this. This got changed to this behavior while fixing findbug  bugs.
Better would be to use enum to represent various better states. But that will require many
changes and can be taken for next release.


> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7932
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Anshul Gangwar
>            Assignee: Anshul Gangwar
>             Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively determine
if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined that VM
is not alive. How can HypervInvestigator determine status of a VM running on Simulator or
any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) HypervInvestigator found VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) Processing HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator] (HA-Worker-1:ctx-e0b5183c
work-1) Unable to reach the agent for VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is
unreachable: Host 1: Host with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) SimpleInvestigator found VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) XenServerInvestigator found VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator] (HA-Worker-1:ctx-e0b5183c
work-1) Not a User Vm, unable to determine state of VM[SecondaryStorageVm|s-1-VM] returning
null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) PingInvestigator found VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator] (HA-Worker-1:ctx-e0b5183c
work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c work-1) Seq
2-5786281096240955453: Sending { Cmd , MgmtId: 1, via: 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992),
Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
}
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c work-1) Seq
2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via: 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992),
Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
}
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c work-1) Seq
2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver: v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl] (HA-Worker-1:ctx-e0b5183c
work-1) host (172.16.15.74) cannot be pinged, returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c work-1) Seq
3-248260929458798725: Sending { Cmd , MgmtId: 1, via: 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7),
Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
}
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c work-1) Seq
3-248260929458798725: Executing: { Cmd , MgmtId: 1, via: 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7),
Ver: v1, Flags: 100011, [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
}
> 2014-11-15 13:35:21,691 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c work-1) Seq
3-248260929458798725: Received: { Ans: , MgmtId: 1, via: 3, Ver: v1, Flags: 10, { Answer }
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.h.AbstractInvestigatorImpl] (HA-Worker-1:ctx-e0b5183c
work-1) host (172.16.15.74) cannot be pinged, returning null ('I don't know')
> 2014-11-15 13:35:21,691 DEBUG [c.c.h.ManagementIPSystemVMInvestigator] (HA-Worker-1:ctx-e0b5183c
work-1) unable to determine state of VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,691 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) ManagementIPSysVMInvestigator found VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) KVMInvestigator found VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) HypervInvestigator found VM[SecondaryStorageVm|s-1-VM]to be alive? false
> 2014-11-15 13:35:21,692 WARN [o.a.c.f.j.AsyncJobExecutionContext] (HA-Worker-1:ctx-e0b5183c
work-1) Job is executed without a context, setup psudo job for the executing thread
> 2014-11-15 13:35:21,725 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) Sync job-116 execution on object VmWorkJobQueue.1
> 2014-11-15 13:35:22,212 DEBUG [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) VM is not HA enabled so we're done.
> 2014-11-15 13:35:22,212 INFO [c.c.h.HighAvailabilityManagerImpl] (HA-Worker-1:ctx-e0b5183c
work-1) Completed HAWork[1-HA-1-Running-Scheduled]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message