Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B34FE173E3 for ; Thu, 16 Oct 2014 11:24:34 +0000 (UTC) Received: (qmail 54844 invoked by uid 500); 16 Oct 2014 11:24:34 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 54817 invoked by uid 500); 16 Oct 2014 11:24:34 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 54807 invoked by uid 500); 16 Oct 2014 11:24:34 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 54802 invoked by uid 99); 16 Oct 2014 11:24:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 11:24:34 +0000 Date: Thu, 16 Oct 2014 11:24:34 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-6278) Baremetal Advanced Networking support MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173630#comment-14173630 ] ASF GitHub Bot commented on CLOUDSTACK-6278: -------------------------------------------- Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/23#issuecomment-59347522 Mostly LGTM. I found a pattern that all the baremetal changes are causing issues, from the JIRA issue [1] this feature is in progress and I would only request @frank-zhang to: - Work in a separate feature branch and send a merge request when you think this feature is ready - Use better git commit messages as I'm unable to understand what Frank's is trying to do, all commits have CLOUDSTACK-6278 as short message which does not make sense to me - Avoid hardcoding stuff in the source code and avoid check in to master [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6278 Thanks and regards. > Baremetal Advanced Networking support > ------------------------------------- > > Key: CLOUDSTACK-6278 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6278 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the default.) > Components: Baremetal > Affects Versions: 4.5.0 > Reporter: frank zhang > Assignee: frank zhang > Fix For: 4.5.0 > > > functional spec link: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Baremetal+Advanced+Networking+Support -- This message was sent by Atlassian JIRA (v6.3.4#6332)