cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-6278) Baremetal Advanced Networking support
Date Thu, 16 Oct 2014 11:24:34 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173630#comment-14173630
] 

ASF GitHub Bot commented on CLOUDSTACK-6278:
--------------------------------------------

Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/23#issuecomment-59347522
  
    Mostly LGTM.
    
    I found a pattern that all the baremetal changes are causing issues, from the JIRA issue
[1] this feature is in progress and I would only request @frank-zhang to:
    
    - Work in a separate feature branch and send a merge request when you think this feature
is ready
    - Use better git commit messages as I'm unable to understand what Frank's is trying to
do, all commits have CLOUDSTACK-6278 as short message which does not make sense to me
    - Avoid hardcoding stuff in the source code and avoid check in to master
    
    [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6278
    
    Thanks and regards.


> Baremetal Advanced Networking support
> -------------------------------------
>
>                 Key: CLOUDSTACK-6278
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6278
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Baremetal
>    Affects Versions: 4.5.0
>            Reporter: frank zhang
>            Assignee: frank zhang
>             Fix For: 4.5.0
>
>
> functional spec link: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Baremetal+Advanced+Networking+Support



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message