Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5826617335 for ; Mon, 29 Sep 2014 20:19:34 +0000 (UTC) Received: (qmail 9443 invoked by uid 500); 29 Sep 2014 20:19:34 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 9410 invoked by uid 500); 29 Sep 2014 20:19:34 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 9400 invoked by uid 500); 29 Sep 2014 20:19:34 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 9397 invoked by uid 99); 29 Sep 2014 20:19:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Sep 2014 20:19:34 +0000 Date: Mon, 29 Sep 2014 20:19:34 +0000 (UTC) From: "Murali Reddy (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CLOUDSTACK-6420) Network implement: use network stateMachine instead of explicitly setting the state on network object MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murali Reddy updated CLOUDSTACK-6420: ------------------------------------- Assignee: (was: Murali Reddy) > Network implement: use network stateMachine instead of explicitly setting the state on network object > ----------------------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-6420 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6420 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Network Controller > Affects Versions: 4.4.0 > Reporter: Alena Prokharchyk > Fix For: Future > > > In NetworkOrchestrator, implementNetwork code, some places use state machine when update the network's state, some just update the network directly. Have to eliminate the latest, and use state machine everywhere. > if (isSharedNetworkWithServices(network)) { > network.setState(Network.State.Implementing); > } else { > stateTransitTo(network, Event.ImplementNetwork); > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)