cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-7528) When AlertManager fails to sendAlert it does not log the actual issue/error
Date Wed, 10 Sep 2014 09:46:28 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128283#comment-14128283
] 

ASF subversion and git services commented on CLOUDSTACK-7528:
-------------------------------------------------------------

Commit f4f5ea3cc02d931416579514a3289a607f7c5cac in cloudstack's branch refs/heads/hotfix/4.4/CLOUDSTACK-7528
from [~rohit.yadav@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f4f5ea3 ]

CLOUDSTACK-7528: More verbose logging when sending alert fails

When sendAlert is called on an AlertManager impl, if it fails it logs that
something was wrong but does not log the body of the issue/error. This means
we tell the user/admin that there was an issue but don't share the "issue"
with them at all as the email alert fail (or that they were not initialized).

(cherry picked from commit 91fd8d7cd5d5a83bf75f5f2972ad2eb2a4a07694)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	server/src/com/cloud/alert/AlertManagerImpl.java


> When AlertManager fails to sendAlert it does not log the actual issue/error
> ---------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7528
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7528
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.2.0, 4.2.1, 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>            Priority: Critical
>             Fix For: 4.5.0, 4.3.1, 4.4.1
>
>
> AlertManager has a sendAlert method, the impls try to send emailAlerts but if they fail
they log it as warning the subject/error but don't log the actual error. This message in logs
is useless for users/admins as we tell them that there is an issue but don't share with them
at all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message