Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 8 Aug 2014 12:40:12 +0000 (UTC)
From: "Rohit Yadav (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12684887.1387169420085.42977.1407501612488@arcas>
In-Reply-To: <JIRA.12684887.1387169420085@arcas>
References: <JIRA.12684887.1387169420085@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-5512) template format name checking
 is crude and doesn't work with advanced URLs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090716#comment-14090716 ] 

Rohit Yadav commented on CLOUDSTACK-5512:
-----------------------------------------

[~shadowsor] Marcus, can you give example of a S3 pre-signed URL? Do you propose we remove the entire extension checking as one would be passing the template type anyway? Or, any other way you want to propose? Fix would be simple.

> template format name checking is crude and doesn't work with advanced URLs
> --------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-5512
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5512
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.0.0, 4.1.0, 4.2.0
>            Reporter: Marcus Sorensen
>             Fix For: 4.4.0
>
>
> Template name checking currently just looks at the very end of the url string. e.g.:
> private void checkFormat(String format, String url) {
>         if((!url.toLowerCase().endsWith("vhd"))
> This breaks functionality such as registering a template via an S3 pre-signed URL, or anything where the file extension is not the last part of the URL. We should at least attempt to parse the URL for filename vs parameters.


--
This message was sent by Atlassian JIRA
(v6.2#6252)