Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Sun, 10 Aug 2014 17:31:12 +0000 (UTC)
From: "David Bierce (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12658700.1374214209981.51287.1407691872196@arcas>
In-Reply-To: <JIRA.12658700.1374214209981@arcas>
References: <JIRA.12658700.1374214209981@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-3658) [DB Upgrade] - Deprecate
 several old object storage tables and columns as a part of 41-42 db upgrade
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092129#comment-14092129 ] 

David Bierce commented on CLOUDSTACK-3658:
------------------------------------------

I was looking into this issue which is fairly severe as it is a data deletion bug. 

https://issues.apache.org/jira/browse/CLOUDSTACK-6254

This looks to be related to old code in UploadManagerImpl.java still using the UploadVO to determine image type.  I assume because the table started returning nothing,  deleteEntityExtractUrl  in CloudStackImageStoreDriverImpl.java always returns volume which leads to templates being extracted for download to be silently deleted from secondary storage.

The top level cleanup, already knows if it is a volume or a template, so I'm looking as a temporary work around to just pass that down through stack, but this issue appears to exist because this was deprecated but there is still code that references the now empty table.  Is there another bug somewhere to clean up references to now deprecated tables?

> [DB Upgrade] - Deprecate several old object storage tables and columns as a part of 41-42 db upgrade
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-3658
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3658
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Install and Setup, Storage Controller
>    Affects Versions: 4.2.0
>            Reporter: Nitin Mehta
>            Assignee: Nitin Mehta
>            Priority: Critical
>             Fix For: 4.5.0
>
>         Attachments: cloud-after-upgrade.dmp
>
>
> We should deprecate the following db tables and table columes as a part of 41-42 db upgrade due to recent object storage refactoring:
> -Upload
> -s3
> -swift
> -template_host_ref
> -template_s3_ref
> -template_swift_ref
> -volume_host_ref
> -columes (s3_id, swift_id, sechost_id) from snapshots table.


--
This message was sent by Atlassian JIRA
(v6.2#6252)