cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Animesh Chaturvedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-7289) Bugs seen when declaring a class variable as native type (long) and have its getter method returning the corresponding object (Long) and vice versa
Date Fri, 22 Aug 2014 05:03:11 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-7289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106461#comment-14106461
] 

Animesh Chaturvedi commented on CLOUDSTACK-7289:
------------------------------------------------

I was hoping Coverity will catch it but because of autoboxing it will consider it ok. The
NPE you mention would be because of another field. Can we write a script to check the occurrences?

> Bugs seen when declaring a class variable as native type (long) and have its getter method
returning the corresponding object (Long) and vice versa
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7289
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7289
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.5.0
>            Reporter: Nitin Mehta
>            Priority: Critical
>             Fix For: 4.5.0
>
>
> Declare a variable as native type (long) and have its getter method
> returning the corresponding object (Long). This is what I fixed with CLOUDSTACK-7272.
> Example below. This should be fixed in the entire code base.
> Autoboxing causes NPE or defaults some values. The vice versa should be
> fixed as well meaning declaring hostId as Long and returning as native
> type (long).
> long hostId
> Long getHostId(){
> return hostId;
> }
> Right Implementation (hostId is declared as Long)
> Long hostId;
> Long getHostId(){
> return hostId;
> }



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message