cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (CLOUDSTACK-5512) template format name checking is crude and doesn't work with advanced URLs
Date Mon, 11 Aug 2014 17:00:14 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rohit Yadav closed CLOUDSTACK-5512.
-----------------------------------

    Resolution: Duplicate

Min already fixed it, https://issues.apache.org/jira/browse/CLOUDSTACK-6940

Marcus please test it and reopen if any fix it needed. Thanks.

> template format name checking is crude and doesn't work with advanced URLs
> --------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-5512
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5512
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.0.0, 4.1.0, 4.2.0
>            Reporter: Marcus Sorensen
>            Assignee: Rohit Yadav
>             Fix For: 4.4.0
>
>
> Template name checking currently just looks at the very end of the url string. e.g.:
> private void checkFormat(String format, String url) {
>         if((!url.toLowerCase().endsWith("vhd"))
> This breaks functionality such as registering a template via an S3 pre-signed URL, or
anything where the file extension is not the last part of the URL. We should at least attempt
to parse the URL for filename vs parameters.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message