Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F1DF311C00 for ; Mon, 21 Jul 2014 18:04:40 +0000 (UTC) Received: (qmail 96629 invoked by uid 500); 21 Jul 2014 18:04:40 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 96593 invoked by uid 500); 21 Jul 2014 18:04:40 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 96577 invoked by uid 500); 21 Jul 2014 18:04:40 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 96574 invoked by uid 99); 21 Jul 2014 18:04:40 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jul 2014 18:04:40 +0000 Date: Mon, 21 Jul 2014 18:04:40 +0000 (UTC) From: "Animesh Chaturvedi (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CLOUDSTACK-7031) [Automation] deployDataCenter.py issues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Animesh Chaturvedi updated CLOUDSTACK-7031: ------------------------------------------- Assignee: Santhosh Kumar Edukulla > [Automation] deployDataCenter.py issues > --------------------------------------- > > Key: CLOUDSTACK-7031 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7031 > Project: CloudStack > Issue Type: Test > Security Level: Public(Anyone can view this level - this is the default.) > Components: Automation > Affects Versions: 4.4.0 > Reporter: Alex Brett > Assignee: Santhosh Kumar Edukulla > Fix For: 4.4.0 > > > In Marvin's deployDataCenter.py on master and 4.4-forward, some functions within the DeployDataCenters class call sys.exit(1) directly. Good practise is for sys.exit to only ever be called from inside a __main__ environment, and not from within a class. > In particular, if using the deployDataCenter.py code as a library rather than invoking it directly, this can result in unexpected application exits if a problem occurs. > In addition, when run directly deployDataCenter.py will always exit with error code 1, even after a successful deploy, which is not helpful to anybody wanting to script the code. > I've prepared a patch against 4.4-forward that resolves these issues (and also tidies up logging by removing calls to print from inside the DeployDataCenters class), which I'll submit for review. I can't assign this ticket to myself however... -- This message was sent by Atlassian JIRA (v6.2#6252)