Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 29 Jul 2014 18:02:39 +0000 (UTC)
From: "Alena Prokharchyk (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12697121.1393335694968.67196.1406656959765@arcas>
In-Reply-To: <JIRA.12697121.1393335694968@arcas>
References: <JIRA.12697121.1393335694968@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-6168) vm.instancename.flag
 inefficient
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078081#comment-14078081 ] 

Alena Prokharchyk commented on CLOUDSTACK-6168:
-----------------------------------------------

vm.instancename.flag applies just to vmWare hypervisor. The logic is the following: 

        if (_instanceNameFlag && hypervisor.equals(HypervisorType.VMware)) { ----logic for vmWare
            if (hostName == null) {
                if (displayName != null) {  ---- if displayName is passed in, then the host name on vmWare hypervisor will be set to displayName (instance.name is ignored)
                    hostName = displayName;
                } else {   --------------------------------------only if display name is equals to NULL, then we will generate the vm's host name as i-xx-xxxx-"instance.name"
                    hostName = generateHostName(uuidName);
                }
            }
        } else {  ------ for all other hypervisors, _instanceNameFlag doesn't have any affect
            if (hostName == null) {
                //Generate name using uuid and instance.name global config
                hostName = generateHostName(uuidName);
            }
        }


I will update the doc for "vm.instancename.flag" saying that this parameter applies to instances starting on VmWare hypervisor only.

> vm.instancename.flag inefficient
> --------------------------------
>
>                 Key: CLOUDSTACK-6168
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6168
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.2.0
>         Environment: Cloudstack 4.2.1 on 
>            Reporter: JF Vincent
>            Assignee: Alena Prokharchyk
>             Fix For: 4.5.0
>
>
> have set vm.instancename.flag to YES, restarted the management server 
> -> started a new instance in my KVM zone with or without any display name => no change on instance name on hypervisor.
> -> started a new instance in my vCenter zone with a display name madrid. Instance name on ESXi is just madrid and not i-xx-xxxx-madrid.
> Regards
> JF


--
This message was sent by Atlassian JIRA
(v6.2#6252)