cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Girish Chaudhari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-5663) API:MS: Network with NULL CIDR raises NPE for createNetwork and listNetwork
Date Thu, 10 Jul 2014 15:39:05 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057599#comment-14057599
] 

Girish Chaudhari commented on CLOUDSTACK-5663:
----------------------------------------------

In the listNetworks and createNetworks execution flow, existing networks analysed to check
whether they can be used for deploy. In this step, all the available IPs are calculated using
the mentioned CIDR. In case the CIDR is NULL it results into the NPE.  We need to add the
NULL check to avoid NPE, in case of NULL CIDR we can populate the "canusefordeploy" attribute
as false. 

> API:MS: Network with NULL CIDR raises NPE for createNetwork and listNetwork
> ---------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-5663
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5663
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API, Management Server
>    Affects Versions: 4.2.0
>         Environment: NA
>            Reporter: Parth Jagirdar
>            Assignee: Girish Chaudhari
>            Priority: Critical
>
> A Zone creation without CIDR is allowed for Shared networks.
> And CIDR is not a required param for Create Network API.
> In such a case listNetworks and createNetworks will raise NPE.
> ERROR [cloud.api.ApiServer] (catalina-exec-13:null) unhandled exception executing api
command: listNetworks
> java.lang.NullPointerException
>         at com.cloud.network.NetworkModelImpl.getAvailableIps(NetworkModelImpl.java:1694)
>         at com.cloud.network.NetworkModelImpl.canUseForDeploy(NetworkModelImpl.java:585)
>         at com.cloud.api.ApiDBUtils.canUseForDeploy(ApiDBUtils.java:1147)
>         at com.cloud.api.ApiResponseHelper.createNetworkResponse(ApiResponseHelper.java:2259)
>         at org.apache.cloudstack.api.command.user.network.ListNetworksCmd.execute(ListNetworksCmd.java:157)
>         at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
>         at com.cloud.api.ApiServer.queueCommand(ApiServer.java:514)
>         at com.cloud.api.ApiServer.handleRequest(ApiServer.java:372)
>         at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:305)
>         at com.cloud.api.ApiServlet.doGet(ApiServlet.java:66)
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
>         at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
>         at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>         at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
>         at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
>         at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
>         at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
>         at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
>         at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
>         at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
>         at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:889)
>         at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
>         at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2266)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>         at java.lang.Thread.run(Thread.java:724)
> 2013-12-26 14:50:05,336 DEBUG [cloud.api.ApiServlet] (catalina-exec-13:null) ===END===
 10.215.2.19 -- GET  command=listNetworks&response=json&sessionkey=umV%2F%2Fe90IumPgdOknf1aBRF0kLE%3D&listAll=true&page=1&pagesize=20&_=1388098205177



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message